Skip to content

Fix first two code samples. #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix first two code samples. #545

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2014

The original sample below will really give out a Reference Error since the function wasn't called in the first place.

function myFunc() { x = 5; }
console.log( x ); // 5

It should be:

function myFunc() { x = 5; }
myFunc()
console.log( x ); // 5

@redbagmoving
Fix first two code samples.
bb10764 
The original sample below will really give out a Reference Error since the function wasn't called in the first place.

function myFunc() { x = 5; }
console.log( x ); // 5
@arthurvr
Copy link
Member

@poweredbycoffee Seems fine. Looks like you haven't signed the CLA, could you handle that? Make sure the name and email in your git config matches the name and email you signed the CLA with.

@ghost
Copy link
Author

ghost commented Jan 5, 2015

Oops sorry. Just signed the CLA this minute!

@ghost
Copy link
Author

ghost commented Jan 5, 2015

@arthurvr My bad. I just re-signed it with Oliver Florentin

@arthurvr
Copy link
Member

arthurvr commented Jan 5, 2015

Perfect.

@RedWolves RedWolves closed this in 2b38106 Jan 8, 2015
Krinkle pushed a commit that referenced this pull request Apr 9, 2024
@redbagmoving @Krinkle
javascript-101/scope.md: Fix first two code samples.
0713b00 
Closes gh-545

The original sample below will really give out a Reference Error since the function wasn't called in the first place.

function myFunc() { x = 5; }
console.log( x ); // 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurvr @RedWolves @agcolom @redbagmoving